search

inyokaproject / theme-default

Inyoka OSS Theme
Other
7 stars 12 forks source link

Extend Form-Macro #194

Open MAH1987 opened 7 years ago

MAH1987 commented 7 years ago

From Lyra2108: It would be great if the macro also had the possibility to detect date/time fields and would show a date picker, because it is hard to know for the user which format is the expected one.

Do we need even more field types?

MAH1987 commented 6 years ago

I would do this next! Anyone see more fieldtypes that we need?

chris34 commented 6 years ago

hm, so you would add more types to https://github.com/inyokaproject/theme-default/blob/staging/inyoka_theme_default/templates/macros.html#L190?

I'm asking as with django 1.11 there's a much cleaner way to solve this: https://docs.djangoproject.com/en/1.11/ref/forms/renderers. That would be IMO also more variable – so we dont have to manually check for every field type in the frontend. Instead each field in the backend is mapped automagically to a template. We should migrate to 1.11 until April ether.

Nevertheless, you can add it for the moment. However, if you have something equally interesting that lasts longer (f.e. adapt a missing template to bootstrap), feel free to do that. :)

MAH1987 commented 6 years ago

Ok then I will adapt a missing template. We should prefer to migrate to the new Djangoversion. Sound "painless"