search

inyokaproject / theme-default

Inyoka OSS Theme
Other
7 stars 12 forks source link

JS Syntax Error in complete.js:1541:8 #220

Closed sebix closed 6 years ago

sebix commented 6 years ago

Badly formatted traceback from the console:

22:00:09.974
Error: Syntax error, unrecognized expression: a[href*=#]:not([href=#])
complete.js:1541:8
Sizzle</Sizzle.error
http://static.ubuntuusers.local:8080/js/complete.js:1541:8
Sizzle</Sizzle.tokenize
http://static.ubuntuusers.local:8080/js/complete.js:2193:4
Sizzle</Sizzle.select
http://static.ubuntuusers.local:8080/js/complete.js:2620:20
Sizzle
http://static.ubuntuusers.local:8080/js/complete.js:845:9
find
http://static.ubuntuusers.local:8080/js/complete.js:2873:4
jQuery.fn.init
http://static.ubuntuusers.local:8080/js/complete.js:2983:14
jQuery
http://static.ubuntuusers.local:8080/js/complete.js:139:10
<anonymous>
http://static.ubuntuusers.local:8080/js/complete.js:12875:3
mightThrow
http://static.ubuntuusers.local:8080/js/complete.js:3534:21
resolve/</process<
http://static.ubuntuusers.local:8080/js/complete.js:3602:12
chris34 commented 6 years ago

hm, this is probably caused by https://github.com/inyokaproject/theme-default/blob/staging/inyoka_theme_default/static/js/smoothscrolling.js#L19

By now i would remove smoothscrolling.js completely and just add scroll-behavior: smooth; to the CSS. That has not the greatest support ever, but scrolling is IMO also not a must-have, just an nice-to-have improvement.

Other opinions?