search

inyokaproject / theme-default

Inyoka OSS Theme
Other
7 stars 12 forks source link

Sidebar #32

Closed MarkusH closed 9 years ago

MarkusH commented 9 years ago

From @chris34 on September 19, 2014 20:21

First the sidebar is some kind of „global“ by using the new macros (see #12, section „Sidebar“). Thus, every time only the macros have to be used. (reconstruction included in issue #14) However, an own less-file does not exist yet. Is it necessary?

Moreover, if wished, the sidebar could be „pushed“ behind the content with col-md-push-* or col-md-pull-* (see Bootstrap Docu). At the moment the sidebar is shown above the content. This only affects mobile devices like smartphones.

Copied from original issue: svijee/inyoka#32

MarkusH commented 9 years ago

From @chris34 on October 13, 2014 22:22

ok, we use the macro for generating the sidebar (see #42). Any other opinions to the still existing questions?

MarkusH commented 9 years ago

From @MAH1987 on October 16, 2014 19:9

lets do it, or hide it on -xs devices ?

Lyra2108 commented 9 years ago

I think we fixed all points in this issue. so it is closed.

chris34 commented 9 years ago

Well, if we would like to readd the affix to the sidebar, this would be the right palce imho. Personally, i do not need an affix (also talked a little bit about that with @mah1987), As a) is Voodoo to implement, b) problematic with very long sidebars, which will be heigher than the screen.

MAH1987 commented 9 years ago

No one has the intention to set up an affix

Lyra2108 commented 9 years ago

So a case of "YAGNI" and done ;)