search

inyokaproject / theme-default

Inyoka OSS Theme
Other
7 stars 12 forks source link

consistent sidebar #42

Closed MarkusH closed 9 years ago

MarkusH commented 9 years ago

From @chris34 on October 7, 2014 19:42

At least I have a question: How to display sidebar options, if a user is logged out? F.e. for ikhaya-articles atm a link to reports is displayed. (if you click it you have to login, in order to create a report) Instead, the button to be informed about new comments will not be displayed. Why? Because the state (has the user already subscribed to it?) of it is unknown befor login. Is this logical? Or should i better change it, so that no buttons are display until a user is logged in? Or alternativly are always displayed?

I added an TODO, because this affects LESS/stylehseet (which is restructured atm by @Lyra2108)

 ./planet/page.html:          {# TODO: swap pencil to the right #}

Copied from original issue: svijee/inyoka/pull/42

MarkusH commented 9 years ago

From @svijee on October 10, 2014 22:10

How to display sidebar options, if a user is logged out? F.e. for ikhaya-articles atm a link to reports is displayed. (if you click it you have to login, in order to create a report) Instead, the button to be informed about new comments will not be displayed. Why? Because the state (has the user already subscribed to it?) of it is unknown befor login. Is this logical? Or should i better change it, so that no buttons are display until a user is logged in? Or alternativly are always displayed?

Good question. IMHO we should only show the most important buttons/links for users who are not logged in. For example, the buttons to subscribe comments or report a mistake in articles. On the other hand, buttons like "Create new thread" or "Answer" should be displayed while you are not logged in… So I would say, we should always check if this button is important in some way and display it, otherwise it should'nt be displayed. Or maybe someone has a better idea…

The rest of the PR looks good so far.

MarkusH commented 9 years ago

To be honest, I hate it if I click a button/link that doesn't show a requirement for login.

MarkusH commented 9 years ago

From @chris34 on October 11, 2014 12:5

Fixed the commented issues. Opened an issue for the login-sidebar-problem (ok, ugly new word ^^).

Lyra2108 commented 9 years ago

@chris34 I think this is outdated. Could you please close it, if this is the case?