remove TODOs in source code

MarkusH commented 9 years ago

From @chris34 on November 4, 2014 22:35

In the default-template-source-code are some TODOs. However, they are hard to find. Thus, the best solution would to delete them and open issues for the same problems instead.

Current occurrences:

  $ grep -r TODO ./themes/default/
  ./static/js/PrivilegeBox.js: * TODO: i18n
  ./static/less/bootstrap/dropdowns.less:// TODO: abstract this so that the navbar fixed styles are not placed here?
  ./templates/planet/page.html:          {# TODO: swap pencil to the right #}
  ./templates/portal/register.html:        {# TODO: link to terms and conditions #}
  ./templates/portal/register.html:      {# TODO: take out the HTML out of captcha and "render" it manually here #}
  ./templates/mails/new_user_password.txt:{#- TODO: add a link to disable the confirm key #}
  ./templates/base.html:          {# TODO: Apps should register themself, and the template should receive some list of active apps #}

Copied from original issue: svijee/inyoka#63

MarkusH commented 9 years ago

From @Lyra2108 on November 25, 2014 10:2

I took a quick look at the todos.

These ones should be fixed in the core and not in the layout branch:

./static/js/PrivilegeBox.js: * TODO: i18n
./templates/portal/register.html: {# TODO: take out the HTML out of captcha and "render" it manually here #}
./templates/base.html: {# TODO: Apps should register themself, and the template should receive some list of active apps #}

This one could be done here, if it is possible to deactivate the key:

./templates/mails/new_user_password.txt:{#- TODO: add a link to disable the confirm key #}

So the only ones which are left are:

[ ] ./templates/portal/register.html: {# TODO: link to terms and conditions #}
[ ] ./templates/planet/page.html: {# TODO: swap pencil to the right #}

Also there is a NOTE:

./themes/default/templates/mails/topic_splited.txt:{# NOTE: Deaktiviert, weil das nicht notwendigerweise der Fall ist...

I would suggest to remove the note and the deactivated part.

schell commented 5 years ago

If you're still looking to create issues from your todos you can use my TODO finding app called src-of-truth, which integrates with github. It will track the TODOs for you, closing them after you've deleted them from your codebase.

schell commented 5 years ago

What format are your html template files in?

inyokaproject / theme-default

remove TODOs in source code #63