search

inyokaproject / theme-default

Inyoka OSS Theme
Other
7 stars 12 forks source link

Article layout #68

Closed Lyra2108 closed 9 years ago

Lyra2108 commented 9 years ago

PR for #62

Only copy & paste of the changes to the legacy branch.

svijee commented 9 years ago

This looks fine for me. The only thing I would appreciate is a bigger title, like a h3 similar to the size of the planet article titles. I think @chris34 and you ( @Lyra2108 ) did discuss nearly the same in IRC, if I understood the backlog correctly.

svijee commented 9 years ago

One Question: Is this rather big gap (displayed in orange) a bug or a feature?

bug

svijee commented 9 years ago

To make it clear: In my opion this gap is too big. ;) Not sure if it's intended or not.

MarkusH commented 9 years ago

Where is the anonymous.png used? Can't we just use http://fortawesome.github.io/Font-Awesome/icon/user/ ?

chris34 commented 9 years ago

@MarkusH i thought about that, too. anonymous.png is hardcoded in the model (same for a user profile btw.) atm i dont know how to fix it…

Lyra2108 commented 9 years ago

A clean solution would be to remove the default icon from the model and set it in the theme. This would require an update of both themes. I think that this would be a good solution because it could also be a good use-case to don't display an icon at all in a theme, if none is set.

A quickfix would be to check if it is the default image and than replace it in the theme.

MarkusH commented 9 years ago

{% if user.is_authenticated() %}{% else %}{% endif %} should work

Lyra2108 commented 9 years ago

It doesn't depend on the status of the user, who views it. It is the picture in a user profile or the picture of a blog in the planet feed, if none is set. But all users will see it.

MarkusH commented 9 years ago

Erm, good point, @Lyra2108. The Python code should then return None and the template check for that.

Lyra2108 commented 9 years ago

But since multiple repos are involved and i don't have the time (or rather the knowledge to do it in time). I would suggest to keep it for this PR as it is and fix it later. If this is fine for you? The other things i will do on Sunday.

chris34 commented 9 years ago

Thats just critisism on minimal problems. Otherwise fine work. ;)