search

inyokaproject / theme-ubuntuusers

Inyoka ubuntuusers.de Theme
Other
5 stars 3 forks source link

Drop inline styles #428

Open chris34 opened 3 years ago

chris34 commented 3 years ago

Sometimes style= is still used in the HTML of this theme. Most of the time, it is questionable if it is still needed at all or inline. Latter html tags can be named with a class and the style moved into an existing CSS stylesheet.

This would also allow a more hardened CSP policy.

KaiserBarbarossa commented 3 years ago

Files containig inline style

./inyoka_theme_ubuntuusers/templates/portal/privmsg/index.html:          <th class="delete" style="white-space: nowrap">{% trans %}Delete{% endtrans %}</th>
./inyoka_theme_ubuntuusers/templates/portal/file_edit.html:    <span style="color:red;">{% trans %}CAUTION: A change of the file destroys all links from articles to this file!{% endtrans %}</span>
./inyoka_theme_ubuntuusers/templates/portal/register.html:      <dd style="display: none"><input type="submit" /></dd><!-- at enter the first submit button is used -->
./inyoka_theme_ubuntuusers/templates/forum/edit.html:      <dd style="display: none"><input type="submit" value="Absenden" name="send" /></dd>
./inyoka_theme_ubuntuusers/templates/forum/edit.html:    <table class="topic" style="position:relative; top:11px">
./inyoka_theme_ubuntuusers/templates/forum/reportlist.html:        <td colspan="5" style="white-space: pre-wrap">{{ topic.reported_rendered }}</td>
./inyoka_theme_ubuntuusers/templates/forum/forum.html:            <span class="description" style="float: right;">
./inyoka_theme_ubuntuusers/templates/forum/topic.html:                  <div style="width: {{ (option.percentage * 3) or 2 }}px;">
chris34 commented 3 years ago 
./inyoka_theme_ubuntuusers/templates/overall.html:        <link rel="stylesheet" type="text/css" href="{{ href('static', 'style', '%s.css'|format(style), v=INYOKA_VERSION) }}" />
./inyoka_theme_ubuntuusers/templates/overall.html:      <link rel="stylesheet" type="text/css" href="{{ href('static', 'style', 'print.css', v=INYOKA_VERSION) }}" media="print" />
./inyoka_theme_ubuntuusers/templates/overall.html:        <link rel="stylesheet" type="text/css" href="{{ href('static', 'style', 'special_day', special_day_css, v=INYOKA_VERSION) }}" />
./inyoka_theme_ubuntuusers/templates/overall.html:      <link rel="stylesheet" type="text/css" href="{{ href('media', 'linkmap', linkmap_css) }}" />

These are not inline styles.

KaiserBarbarossa commented 3 years ago

These are not inline styles.

Oh yes. Sorry but I forgot deleting that lines when I posted the output.