search

inys / covid-dashboard-js

Vue3/plotly.js code to display public covid data of France
MIT License
6 stars 0 forks source link

Wrap into a standalone vue3-plotly package #1

Open AdeBC opened 2 years ago

AdeBC commented 2 years ago

Congratulations on your good work!

I have been struggling to find a Plotly wrapper for vue3 all day and tried to implement that myself. Fortunately, I found you repository actually contains some code that adapts the Plotly wrapper for vue2 to vue3. It works for both Bubblemap and Barplot, and it seems you didn't implement this vue3-plotly wrapper only for several kinds of plots. Your code can be directly used in my project (and I guess even more), I'm also considering whether it is possible to wrap your code into a standalone package serving as a vue3-plotly (as currently there is no such package in the community).

Just want to let more people know your code and use your code, that will greatly help them. A vue3-plotly package is in urgent need but no one except you seems already close to there.

No obligation please, this is just a suggestion. Thanks very much:smile:!

AdeBC commented 2 years ago

I have shared your repository on Twitter so that more people can know there is a wonderful resource.

inys commented 2 years ago

Thanks a lot!

As I wrote in the README.md I've copied this component from David-Desmaisons/vue-plotly. I've had to add his files and change the hook-function from "beforeDestroy" to "beforeUnmount" in Plotly.vue, since the former does not exist in Vue3.

Since this satisfied my purposes, I haven't thought about a package, but I will work on that.

AdeBC commented 2 years ago

Thank you!

I can also help but I'm just new to this. Maybe I can help finish the documentation （use-cases or staffs like that）if you need.