inzlain / SushiTrain

A payload management and delivery framework
GNU General Public License v3.0
1 stars 1 forks source link

Make X-Forwarded-For behaviour configurable at the redirector level #2

Open inzlain opened 6 days ago

inzlain commented 6 days ago

Implement functionality to allow users to configure the X-Forwarded-For behaviour on each redirector.

Possible values could include:


Decide on the best default behaviour:

My instinct says revert back to left-most but implement the non-private check. Only possible edge case I see is if there is no non-private IP (i.e. dev/testing), but this could be addressed by reconfiguring the redirector or having a fallback to just take the leftmost if there is only private addresses.


Update the CDN specific redirector documentation to include recommendations on how this should be set for specific CDNs / tech stacks.

th3Bak3r commented 6 days ago

Agreed that defaulting to left-most (for better compatibility) in combination with user-configuration function (regexes?) would work well.

I did have some thoughts around CDN vendor specific presets, but that could end up badly as vendors love changing things all the time.