Open inzlain opened 6 days ago
Agreed that defaulting to left-most (for better compatibility) in combination with user-configuration function (regexes?) would work well.
I did have some thoughts around CDN vendor specific presets, but that could end up badly as vendors love changing things all the time.
Implement functionality to allow users to configure the
X-Forwarded-For
behaviour on each redirector.Possible values could include:
X-Forwarded-For
) - This could let the user have an option to work around any unruly CDNs or tech stacks that don't have any sane behaviour.Forwarded
header - Decide if we can/should also add support for Forwarded header now being implemented by some tech stacks.Decide on the best default behaviour:
My instinct says revert back to left-most but implement the non-private check. Only possible edge case I see is if there is no non-private IP (i.e. dev/testing), but this could be addressed by reconfiguring the redirector or having a fallback to just take the leftmost if there is only private addresses.
Update the CDN specific redirector documentation to include recommendations on how this should be set for specific CDNs / tech stacks.