search

io-developer / php-whois

PHP WHOIS provides parsed and raw whois lookup of domains and ASN routes. PHP 8.0 compatible (5.4+ old versions)
MIT License
437 stars 117 forks source link

Package true/punycode is abandoned, you should avoid using it. #190

Closed JamesShaver closed 1 year ago

JamesShaver commented 2 years ago

Description
The true/punycode github is archived, and no longer maintained. A replacement is suggested at: https://github.com/symfony/polyfill-intl-idn

skiner68 commented 1 year ago

+1 on this. I have just removed true/punycode dependency from my project. Later it came back as third party dep when I needed to make some whois queries.

mikedodd commented 1 year ago

+1 on this, I really don't like having abandoned packages

bessone commented 1 year ago

If anyone has time to test the new PR #195 , it would be a good idea to go ahead

io-developer commented 1 year ago

If anyone has time to test the new PR #195 , it would be a good idea to go ahead

I reviewed PR - https://github.com/io-developer/php-whois/pull/195#pullrequestreview-1240568574 It should be simplified to 1 or 2 commit and it requires much less changes :)

io-developer commented 1 year ago

I can check it later. Maybe will fix it by myself..

io-developer commented 1 year ago

Merged