io7m / android

The Android client for Library Simplified
Other
0 stars 0 forks source link

DRMLicensors overwritten in feeds #11

Closed io7m closed 6 years ago

io7m commented 6 years ago

The current code scans OPDS feeds one entry at a time and ends up using whichever DRM licensor it encounters last. The code should instead be storing a list of the licensors it encounters: A silent assumption that all DRM licensors in a feed are the same licensor sounds like an incredibly nasty bug to track down when that assumption later turns out to be incorrect.

io7m commented 6 years ago

I don't know enough about the DRM system now to fix this. I've switched to storing a set of licensors, but the set will only contain the one licensor the feed gives me. This should be an easy fix for someone who knows the DRM system better (or can enlighten me as to why the licensor information will actually always be the same but will be placed repeatedly throughout the OPDS feed).