Developers can add a message for certain updates to their io-package.json. It is possible to add link and linkText properties to that message containing more information. I'd expect to see the linkText as Button description and from looking at the code, it seems that this also is intended, but for some reason I do not understand (otherwise I'd do a PR :smile: ) it always falls back to 'More info'.
Additional information:
'More info' is not in the translation, hence it is logged in the console. Might that cause a side effect? Since that is the most visible difference between linkText and the other texts. (see https://github.com/ioBroker/ioBroker.admin/blob/master/packages/admin/src-admin/src/dialogs/AdapterUpdateDialog.tsx#L579 ). I'd recommend either adding "More info" to the translations or replace the fallback with "Show more info" which is already in the translations and there is ample space. :-)
To Reproduce
To reproduce add some messages object to an adapter, maybe by editiong system.repositories and downgrade one adapter to match the message condition and see the messge. It's always more info.
No existing issues.
Describe the bug
Developers can add a message for certain updates to their io-package.json. It is possible to add
link
andlinkText
properties to that message containing more information. I'd expect to see the linkText as Button description and from looking at the code, it seems that this also is intended, but for some reason I do not understand (otherwise I'd do a PR :smile: ) it always falls back to 'More info'.Additional information: 'More info' is not in the translation, hence it is logged in the console. Might that cause a side effect? Since that is the most visible difference between linkText and the other texts. (see https://github.com/ioBroker/ioBroker.admin/blob/master/packages/admin/src-admin/src/dialogs/AdapterUpdateDialog.tsx#L579 ). I'd recommend either adding "More info" to the translations or replace the fallback with "Show more info" which is already in the translations and there is ample space. :-)
To Reproduce
To reproduce add some messages object to an adapter, maybe by editiong
system.repositories
and downgrade one adapter to match the message condition and see the messge. It's always more info.Example messages array to add (adjust versoin):
Expected behavior
Button to more info should show linkText.
Screenshots & Logfiles
(english and german)
It also fails, if linkText is just a string, not an object.
Adapter version
6.17.14
js-controller version
5.0.19
Node version
v18.20.2
Operating system
Linux Server 6.5.0-41-generic #41-Ubuntu SMP PREEMPT_DYNAMIC Mon May 20 15:55:15 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Additional context
No response