ioBroker / ioBroker.admin

user interface for configuration and administration
https://iobroker.net
MIT License
272 stars 78 forks source link

[bug]: Invalid Request when trying to display licenseInformation /Licensetype 'limited') #2557

Closed mcm1957 closed 2 months ago

mcm1957 commented 3 months ago

No existing issues.

Describe the bug

When trying to install KNX Adapter instead of some licensinformation an errormessage 400: Invalid request is displayed.

Chrome Console log:

[ADAPTERS] 2024-07-19T06:56:15.186Z Update cache!
console.ts:40 Render because of cachedAdapters 622 <> 0
2console.ts:40 Render because of listOfVisibleAdapter
console.ts:40 [ADAPTERS] 2024-07-19T06:56:20.843Z Update cache!
console.ts:40 Render because of cachedAdapters 378 <> 622
2console.ts:40 Render because of listOfVisibleAdapter
console.ts:40 [ADAPTERS] 2024-07-19T06:56:21.274Z Update cache!
console.ts:40 Render because of cachedAdapters 7 <> 378
2console.ts:40 Render because of listOfVisibleAdapter
console.ts:40 [ADAPTERS] 2024-07-19T06:56:21.779Z Update cache!
console.ts:40 Render because of cachedAdapters 4 <> 7
console.ts:40 Render because of listOfVisibleAdapter
raw.githubusercontent.com/ioBroker/ioBroker.knx?tab=readme-ov-file#license-requirements/master/LICENSE:1 

       Failed to load resource: the server responded with a status of 400 ()
console.ts:40 Render because of descWidth
LicenseDialog.tsx:61 

       GET https://raw.githubusercontent.com/ioBroker/ioBroker.knx?tab=readme-ov-file 400 (Bad Request)```

io-package looks good:

https://github.com/ioBroker/ioBroker.knx/blob/337ce152b2fa3f98913bb001c025610e5eb6a3fa/io-package.json#L313

"licenseInformation": { "link": "https://github.com/ioBroker/ioBroker.knx?tab=readme-ov-file#license-requirements", "type": "limited", "license": "CC-BY-NC-4.0" }



Looks like #license-requirements is truncated - but this should not invalidate the url itself.

Please check

### To Reproduce

1. Try to install knx using current stable version

### Expected behavior

The licenseinfo should be displayed

### Screenshots & Logfiles

![image](https://github.com/user-attachments/assets/dff2d9e1-d720-440d-ad04-fb6a7edda8af)

![image](https://github.com/user-attachments/assets/426b8e98-4473-4ab4-963f-f543637f91e5)

### Adapter version

Admin 7.0.17 / KNX 2.0.28

### js-controller version

6.0.5

### Node version

20.15.0

### Operating system

windows 10

### Additional context

Note that adapter is of type LIMITED
mcm1957 commented 3 months ago

Nachtrag: Have been told that problem occures at JAEGERDESIGN Adapter too. Indicates relation with non-free adapters

mcm1957 commented 3 months ago

I suggest to check https://github.com/ioBroker/ioBroker.admin?tab=readme-ov-file#7018-2024-07-22