[enhancement]: Remove the adapter-core override after v7

foxriver76 commented 2 months ago

No existing issues.

[X] There is no existing issue for my request.

Description

The temporary solution has the downside, that adapters can no longer specify the version required. We then have an override in v6 + v7 so every user should once have these version to get the fixes in. Note on new installations etc this is not an issue at all because npm will pull in newer versions anyway.

Why?

The override blocks specyfing different versions and tightly binds adapter-core version to the controller

How?

Modify the override code:

do no longer create the override
remove the override from pack json programmaticaly
remove the override info from readme

Erwin40 commented 1 day ago

Ich frag jetzt mal doof :-) Unter /opt/iobroker die Datei package.json einfach editieren? Ich habe dort den Eintrag drin:

{
    "dependencies": {
        "@iobroker/adapter-core": "^3.1.6",
        "@iobroker-javascript.0/audio": "npm:audio@^1.2.0",
        "@iobroker-javascript.0/onoff": "npm:onoff@^6.0.3",
        "@iobroker-javascript.0/ping": "npm:ping@^0.4.4",
        "@iobroker-javascript.0/systeminformation": "npm:systeminformation@^5.23.5",
        "iobroker.admin": "7.1.5",
        "iobroker.backitup": "3.0.25",
        "iobroker.daswetter": "3.1.16",
        "iobroker.discovery": "5.0.0",
        "iobroker.echarts": "github:ioBroker/ioBroker.echarts#a5f79d6f6e744b1260e729db42998290d7437b78",
        "iobroker.email": "1.3.1",
        "iobroker.fronius": "2.1.1",
        "iobroker.jarvis": "github:Zefau/ioBroker.jarvis#2e8d693817c400667e0289ed12d0e017f7d6edfd",
        "iobroker.javascript": "8.8.3",
        "iobroker.js-controller": "7.0.3",
        "iobroker.lgtv": "2.2.0",
        "iobroker.modbus": "6.3.2",
        "iobroker.mqtt": "6.1.2",
        "iobroker.reolink": "1.1.2",
        "iobroker.roborock": "0.6.17",
        "iobroker.snmp": "3.2.0",
        "iobroker.sql": "3.0.1",
        "iobroker.tankerkoenig": "3.4.0",
        "iobroker.tr-064": "4.3.0",
        "iobroker.web": "6.2.5",
        "iobroker.zigbee": "1.10.3"
    },
    "description": "Automate your Life",
    "engines": {
        "node": ">=12.0.0"
    },
    "name": "iobroker.inst",
    "overrides": {
        "@iobroker/adapter-core": "^3.2.1"
    },
    "packageManager": "yarn@1.22.22+sha1.ac34549e6aa8e7ead463a7407e1c7390f61a6610",
    "private": true,
    "version": "3.0.0"
}

mcm1957 commented 1 day ago

Ich frag jetzt mal doof :-) Unter /opt/iobroker die Datei package.json einfach editieren? Ich habe dort den Eintrag drin:

Auf was bezieht sich diese Frage? Warum willst du das tun? Bist du sicher dass du im richtigen Issue postest?

Und nein, keinesfalls auf deinem System irgendwelche Dateien die von ioBroker oder einem Adapter installiert werden selbst editieren.

Und falls ein Problem existiert, bitte ein neues Issue öffnen oder noch besser vorher im Forum ("https://forum.iobroker.net) ein Topic anlegen.

HIER ist das ziemlich offtopic.

ioBroker / ioBroker.js-controller