ioBroker / ioBroker.js-controller

ioBroker controller
http://iobroker.net
MIT License
294 stars 60 forks source link

Add "verifiedCompact" in repo files and use it in controller #345

Open Apollon77 opened 5 years ago

Apollon77 commented 5 years ago

To prevent users having too strange problems with compact mode adapters that are not clean we should have a "verifiedCompact" entity which is only setable by us.

When someone uses a adapter in compact mode which is not in the list he gets a warning in logs and maybe also in admin when he tries to activate it as "compact". When adapter is added the adapters not in the list should also not configured as "use comact mode" by defaukt - only manually.

So: Protect users for themselfes.

AlCalzone commented 5 years ago

I like having this in repo files :+1: . We should avoid hardcoding stuff (like unsafe-perm for zwave) in the future.

Apollon77 commented 5 years ago

Infos from #428:

... the more interesting question is how we do the process to allow someone set this flag to true ;-)

Should we enhance statistics to also send compact mode active Info beside Version and also show in in adapter list (x% run in compact Mode)

And which adapters we should set initially? But we should discuss this finally in the separate issue

foxriver76 commented 2 years ago

Should we enhance statistics to also send compact mode active Info beside Version and also show in in adapter list (x% run in compact Mode)

I would prefer this one over hard coded flag which needs to be reviewed etc. More like allowing admin to process these statistics and showing an according label. However, compact is still an edgy topic as Pis etc having more and more RAM

mcm1957 commented 1 year ago

I would like to discuss this in a more general way. Some sort of reporting / flagging should be considered to get infos like

I think there are many adapters out in stable and much much more in latest which are no longer maintained. They might work - or not. Theres no way currently, that those adapters are marked so that especially unexpirenced users see the "quality" of an adapter. One example could be, that the maintaienr must confirm, that the adapter is still maintained i.e. once a year etc. Deatils / ideas should be discussed.