Fixes for already paired Devices - Githubissues

ioBroker / ioBroker.maxcul

Control max! devices over CUL stick

Other

4 stars 8 forks source link

Fixes for already paired Devices #11

Closed ghost closed 4 years ago

ghost commented 6 years ago

Sorry, in am really new in GitHub.. :-(

I fixed the following Errors In these Events: ShutterContactStateReceived,ThermostatStateReceived, PushButtonStateReceived

If there was a already paired but new Device. It was created without the "Type" "value" it was created with a "SRC" and "SERIAL" in lowercharacters so it could not be found in the devices list because of a conversion to UpperCharacters and never received DATA

AND in the normal Message from a Device there is no RAW part. so i removed the extraction of the raw information for the device src. Because it was resulting in different device Names, some devices have only there ID as SRC and Name and if i start a new pairing the Device gets a complete different SRC and Name

ALSO in the event "ShutterContactStateReceived" was a createButton(data); at the End instead of the Correct createContact(data);

AT LEAST in CreateContact i changed the Text from "Button" to "Window Contact"

Hope this Helps

Thank You Very much

GermanBluefox commented 5 years ago

Do you have MAX! devices? Does it work? :)

GermanBluefox commented 5 years ago

Is it still actual?

Apollon77 commented 5 years ago

@Illumnus could you please try to resolve the conflicts and then we can do a firum test

ghost commented 5 years ago

@Illumnus could you please try to resolve the conflicts and then we can do a firum test

I have resolved the conflict and testet in My System.

Apollon77 commented 5 years ago

I can merge it later. If you like add version and changes in io-Package and package and readme then i‘m faster ;-)

Then we can have other Forum User Test it ;-)

GermanBluefox commented 5 years ago

???

Apollon77 commented 5 years ago

@GermanBluefox This is because of the old serialport version that do not support nodejs 10 ... so testing is green beside the two node10 tests

GermanBluefox commented 5 years ago

@GermanBluefox This is because of the old serialport version that do not support nodejs 10 ... so testing is green beside the two node10 tests

Merge?

Apollon77 commented 5 years ago

Yes. Nodejs 10 stays unsupported. Ok

Apollon77 commented 5 years ago

@Illumnus

@bowao did a review of your PR and I would follow his words: What do you say about that?

Regarding the pull request #11 I have never noticed this behavior in my setup, but I tested it.

I made renewals of my pairing with one of my shutter contacts in different starting points as follows:

Without deleting it from iobroker and without device reset.
Without deleting it from iobroker but doing a device reset
Deleting it from iobroker but without device reset.
Deleting it from iobroker and do a device reset.

In all cases the shutter contact was created with src and serial correctly and messages from device were received without any problems.

The only way to generate the described behavior, was if the device was never paired with the maxcul-adapter. (Pair Button on device never pressed) In this case the device was named by src when the CUL received a normal state message. But this is in my opinion a normal behavior, because there is no serial in the state message.

Therefore, I can not recommend merging pull request #11!

But in one thing he was right:

The shutter contact is named wrong in the ,,createShutterContact function" ("Push Button" instead of "Shutter Contact").

And I have seen another minor issue in this part of code:

In case of receiving a message from an unknown shutter contact device, the function createButton is called instead of createShutterContact.

But imho these are minor issues.

GermanBluefox commented 4 years ago

@Illumnus can we close it?