search

ioBroker / ioBroker.maxcul

Control max! devices over CUL stick
Other
4 stars 8 forks source link

Boost duration has incorrect unit & missing default values #18

Closed systemofapwne closed 4 years ago

systemofapwne commented 5 years ago

It shows as "sec" in iobroker while it actually seems to be minutes.

Can be easily fixed if one changes this line accordingly. https://github.com/ioBroker/ioBroker.maxcul/blob/392ed8de32482df66130ae46559938c4fdfdb753/main.js#L777

I would also suggest to set a default value to all "config" and "valveConfig" sub-values because they seem to be empty by default and will not get pushed by the devices back to ioBroker.

My suggestions (values not in <> resembles the manufactures default values): valveConfig boostDuration: 5min boostValvePosition: 100% decalcificationDay: <unsure - I have set it to Monday> decalcificationHour: <unsure - I have set it to 14h> maxValveSetting: 100% valveOffset: 0%

config comfortTemperature: 21 ecoTemperature: 17 maximumTemperature: <unsure - I have set it to 30> minimumTemperature: <unsure - I have set it to 15> offset: 0 windowsOpenTemperature: <unsure - I have set it to 15>

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days. Please check if the issue is still relevant in the most current version of the adapter and tell us. Also check that all relevant details, logs and reproduction steps are included and update them if needed. Thank you for your contributions. Dieses Problem wurde automatisch als veraltet markiert, da es in letzter Zeit keine Aktivitäten gab. Es wird geschlossen, wenn nicht innerhalb der nächsten 7 Tage weitere Aktivitäten stattfinden. Bitte überprüft, ob das Problem auch in der aktuellsten Version des Adapters noch relevant ist, und teilt uns dies mit. Überprüft auch, ob alle relevanten Details, Logs und Reproduktionsschritte enthalten sind bzw. aktualisiert diese. Vielen Dank für Eure Unterstützung.

stale[bot] commented 4 years ago

This issue has been automatically closed because of inactivity. Please open a new issue if still relevant and make sure to include all relevant details, logs and reproduction steps. Thank you for your contributions. Dieses Problem wurde aufgrund von Inaktivität automatisch geschlossen. Bitte öffnet ein neues Issue, falls dies noch relevant ist und stellt sicher das alle relevanten Details, Logs und Reproduktionsschritte enthalten sind. Vielen Dank für Eure Unterstützung.