"root path" is no longer used in the settings

ioBroker / ioBroker.node-red

Instantiate the server with node-red

Apache License 2.0

52 stars 27 forks source link

"root path" is no longer used in the settings #288

Closed SBorg2014 closed 2 years ago

SBorg2014 commented 2 years ago

If you enter a path in the root path, it will not be used. For example /node-red, then the dashboard is not as expected under /node-red/ui but only under /ui.

Apollon77 commented 2 years ago

@jwiesel Any idea? I think you did latest changes in config stuff? Maybe you arefaster then me to look into it :-)

jwiesel commented 2 years ago

Hi @SBorg2014 , @Apollon77 , I just checked, what happened.

So far ioBroker.node-red used setting "httpRoot"
This setting has been deprecated by the node-red project: https://github.com/node-red/node-red/pull/2953
The default settings.js being used as a starting point for ioBroker.node-red have been changed to use "httpAdminRoot" in the latest version
The setting "httpNodeRoot" is not used until now.

I see two options, how to change the behavior

Mimic the old behavior of ioBroker.node-red by setting the same value for "httpAdminRoot" and "httpNodeRoot". --> It would contradict the reason of Node-Red to deprecate the setting, but would be the fastest fix.
Add a new instance parameter in ioBroker.node-red to allow setting the httpNodeRoot. (Setting a default value might have an impact on users who changed "httpRoot" in their instance.)

I am open either way. :-)

Apollon77 commented 2 years ago

WHat about adding a second field and have it separated but add faillbacks in Admin-UI JS and main.js - if new field is null or any "default" value and the httpRoot is set to set both to the same value ... Then we achieve basically "backward compatibility" but have both fields separated configurable?

I hope i got the topic right ;-)

SBorg2014 commented 2 years ago

@jwiesel Hmm, i think option "1" is more like an Q&D? No one realy knows how long it does work. I prefer Option "2". A major version change of the adapter from V2.x to V3.x brings a breaking change with it. The default could be /, that doesn't bother the user who hasn't set a path before. Users like me then have to adjust the path again ;)

@Apollon77 Then i'm out ^^

jwiesel commented 2 years ago

Hi @SBorg2014 , @Apollon77 , I just created PR #292 to add the requested functionality. Feel free to test and provide feedback via the URL provided in the PR.

SBorg2014 commented 2 years ago

What should i say? Great job 👍 Works perfect, thank you, merci, danke 😎