ioBroker / ioBroker.repositories

Repositories for ioBroker project
MIT License
139 stars 284 forks source link

Update panasonic-comfort-cloud to 3.0.2 #3805

Closed marc2016 closed 1 month ago

mcm1957 commented 1 month ago

@marc2016 Please update / enable standard github testing. Currently integration testing is disabled:

      - name: Run local tests
        run: npm test
#      - name: Run unit tests
#        run: npm run test:unit
#      - name: Run integration tests # (linux/osx)
#        if: startsWith(runner.OS, 'windows') == false
#        run: DEBUG=testing:* npm run test:integration
#      - name: Run integration tests # (windows)
#        if: startsWith(runner.OS, 'windows')
#        run: set DEBUG=testing:* & npm run test:integration

I would suggest to replace test_and_release workflow with up to date version (i.e. from template adapter). package tests and integrations tests are mandatory. Of course you can add additional tests if you like.

And please remove node 16 tests (they will fail anyway) and consider addint node 22 to testing matrix (node 22 is suggested but not yet mandatory)

I can provide a PR to do the required changes if you prefer. Please comment if preferred.

remoinder 19.7.2024

marc2016 commented 1 month ago

Thank you very much for the hint :-) I changed to the new workflow.

github-actions[bot] commented 1 month ago

Automated adapter checker

ioBroker.panasonic-comfort-cloud

Downloads Number of Installations (latest) Number of Installations (stable) - Test and Release NPM

:thumbsup: No errors found

Adapter releases: https://www.iobroker.dev/adapter/panasonic-comfort-cloud/releases Adapter statistic: https://www.iobroker.dev/adapter/panasonic-comfort-cloud/statistics

History and usage information for release 3.0.2:

3.0.2 created 10.7.2024 (2 days old) 24 users (6.56%)

2.3.0 (stable) created 21.12.2023 (204 days old) 208 users (stable) (56.83%)

Please verify that this PR really tries to update to release 3.0.2!

Add comment "RE-CHECK!" to start check anew

marc2016 commented 1 month ago

@mcm1957 the Adapter does not work anymore in previous versions, because Panasonic switch the login process to OAuth. Until the release to stable no one can use the adapter from stable repo.

mcm1957 commented 1 month ago

OK thanks for Info. Will release immidiatly of course.

marc2016 commented 1 month ago

OK thanks for Info. Will release immidiatly of course.

Thank you 👍🏻