ioBroker / ioBroker.repositories

Repositories for ioBroker project
MIT License
139 stars 287 forks source link

Add waste-collection-erding to latest #4251

Closed Sickboy78 closed 3 weeks ago

Sickboy78 commented 1 month ago

Please add my adapter ioBroker.waste-collection-erding to latest.

This pull request was created by https://www.iobroker.dev c0726ff.

github-actions[bot] commented 1 month ago

Automated adapter checker

ioBroker.waste-collection-erding

Downloads - Test and Release NPM

:thumbsup: No errors found

Add comment "RE-CHECK!" to start check anew

github-actions[bot] commented 1 month ago

ioBroker repository information about New at LATEST tagging

Thanks for spending your time and providing a new adapter for ioBroker.

Your adapter will get a manual review as soon as possible. Please stand by - this might last one or two weeks. Feel free to continue your work and create new releases. You do NOT need to close or update this PR in case of new releases.

In the meantime please check any feedback issues logged by automatic adapter checker and try to fix them. And please check the following information if not yet done:

You will find the results of the review and eventually issues / suggestions as a comment to this PR. So please keep this PR watched.

If you have any urgent questions feel free to ask. mcm1957

@simatec Please take a look in respect to responsive design. Thanks

reminder 9.11.2024

mcm1957 commented 1 month ago

@klein0r @Sickboy78

Does the existing adapter trashschedule (https://github.com/klein0r/ioBroker.trashschedule) already support "erding"? If not, wouldn't it be an option to integrate this supplier into trashschedule? I assume that klein0r will accept a PR for this. Do we need another waste adapter dedicated to a region?

@Apollon77 Some general oppinion?

Sickboy78 commented 1 month ago

Imho Erding is currently not supported since LK Erding does not provide an ICAL calender (only ICS and CSV for download) and the API portal.awido.de is not integrated into trashschedule. But it would totally make sense to integrate it, if this is possible. Need to take a closer look though ...

mcm1957 commented 1 month ago

I would suggest that you take a look if you have time and eventually discuss a solution with klein0r. Let's wait for the result. Thanks for you cooperation.

simatec commented 1 month ago

If the adapter can be integrated independently and not in Trashschedule, I would ask you to migrate the adapter to jsonConfig.

Sickboy78 commented 3 weeks ago

@klein0r @mcm1957

While digging into the Awido API for integration with trashschedule, I found that it is used by nearly 50 districts and cities, i.e. it would add hundreds of cities to be available in trashschedule. So heres the PR: https://github.com/klein0r/ioBroker.trashschedule/pull/285

Sickboy78 commented 3 weeks ago

Functionality was integrated with trashschedule, therfore canceling this PR.