Add mempool-space to latest

[Hans-Wurst-21]

Please add my adapter ioBroker.mempool-space to latest.

This pull request was created by https://www.iobroker.dev c0726ff.

[github-actions[bot]]

Automated adapter checker

ioBroker.mempool-space

-

:thumbsup: No errors found

• [ ] :eyes: [W401] Cannot find "mempool-space" in latest repository

Add comment "RE-CHECK!" to start check anew

[github-actions[bot]]

ioBroker repository information about New at LATEST tagging

Thanks for spending your time and providing a new adapter for ioBroker.

Your adapter will get a manual review as soon as possible. Please stand by - this might last one or two weeks. Feel free to continue your work and create new releases. You do NOT need to close or update this PR in case of new releases.

In the meantime please check any feedback issues logged by automatic adapter checker and try to fix them. And please check the following information if not yet done:

• https://github.com/ioBroker/ioBroker.repositories?tab=readme-ov-file#requirements-for-adapter-to-get-added-to-the-latest-repository
• https://github.com/ioBroker/ioBroker.repositories?tab=readme-ov-file#development-and-coding-best-practices
• https://github.com/iobroker-community-adapters/responsive-design-initiative/tree/main#responsive-design-initiative

You will find the results of the review and eventually issues / suggestions as a comment to this PR. So please keep this PR watched.

If you have any urgent questions feel free to ask. mcm1957

@simatec Please take a look in respect to responsive design. Thanks

[mcm1957]

reminder 24.11.2024

[simatec]

jsonConfig looks good ;)

[mcm1957]

@Hans-Wurst-21

First of all - THANK YOU for the time and effort you spend to maintain this adapter.

I would like to give some feedback based on my personal oppinion. @Apollon77 might have additional suggestions or even a different oppinion to one or the other statement. Please feel free to contact him if you cannot follow my suggestions or want to discuss some special aspects.

• [ ] some labels seem obsolete

  labels 'option1' and 'option2' could be delegted from i18n files. (non blocking remark)

• [ ] consider using adapter.setTimeout / this.setTimeout instead of (standard) setTimeout

  The adapter package provides wrapper routines for native setTimeout, setInterval, clearTimeout and clearInterval. Using those routines ensures that timers are cancelled on on load. Additional checks on thomse limits might be performed, too. So consider replacing native setTimeout/clearTimeout by adapter.setTimeout/adapter.clearTimeout or this.setTimeout/this.clearTimeout. The same refers to setInterval/clearInterval.

• [ ] linter setup

  Please use standard iobroker linter setup. This is located at @iobroker/eslint-config. See migration guide at https://github.com/ioBroker/ioBroker.eslint-config/blob/main/MIGRATION.md

Thanks for reading and evaluating this suggestions. McM1957

Please add a comment when you have reviewed and fixed the suggestionsor at least commented the suggestions and you think the adapter is ready for a re-review!

[mcm1957]

As the noted remarks are minimal and non blocking, I would ask to review / check / fix them with the next release. I will release tot adapter anyway.

[mcm1957]

This adapter has been released to latest repository and should be visible within 24h maximum.

Please create a thread at https://forum.iobroker.net/category/91/tester titled like "Test Adapter " to collect some user feedback and provide a link to this topic when requesting addition to stable repository later.

Note: If an other testing topic already exists, it' OK to continue using this topic too.

[Hans-Wurst-21]

@mcm1957 I have accepted your comments and changed it to v.0.0.4. Please look over the code again if you like.