ioBroker / ioBroker.sonoff

Control Sonoff-Tasmota devices via ioBroker
MIT License
37 stars 28 forks source link

Rename Adapter to ioBroker.tasmota #228

Closed jwiesel closed 2 years ago

jwiesel commented 2 years ago

Is your feature request related to a problem? Please describe. I didn't realize at first, that there is an ioBroker adapter for Tasmota devices. My assumption was, that the Sonoff adapter would be for sonoff devices running on the stock firmware of Sonoff. If I understand it correctly the purpose of this adapter is to connect devices running on the "Tasmota" firmware. Initially the Tasmota firmware was designed for devices manufatured by Sonoff. In the early days the project was still called "Sonoff-Tasmota". As the firmware is compatible to various ESP based devices, that has changed. Sonoff-Tasmota got renamed to "Tasmota" as today >90% of devices running on Tasmota are not coming from Sonoff, but from other vendors.

Therefore other users might face the same situation building a custom MQTT solution to integrate their non-Sonoff tasmota devices in ioBroker instead of using this adapter.

Describe the solution you'd like Rename the adapter to "ioBroker.tasmota", or to ease transition for existing users to "ioBroker.sonoffTasmota".

Additional context If we give the adapter a new name it might look more official. We could even approach the Tasmota project to integrate the adapter into the Tasmota docs as "ioBroker Integration" as well. So far the Tasmota documentation only contains a link to an issue, but no hint, that this adapter could be used: https://tasmota.github.io/docs/Integrations/

Apollon77 commented 2 years ago

I'm against a rename, but a rerwrite in a clean new adapter and then deprecate this one. see also my words in https://github.com/ioBroker/ioBroker.sonoff/issues/69#issuecomment-983569175

The needed changes to be "a generic tasmota" adapter also as bassis for meaningful support would require breaking changes and then a new adapter is the better approach

jwiesel commented 2 years ago

I just had a look at the iobroker.sonoff code and realized how much special handling there is for various kinds of data formats.

Tasmota offers MQTT Auto-discovery: https://tasmota.github.io/docs/Commands/#setoption19

Maybe auto-discovery combined with a MQTT client and some logic to create & sync objects would be an approach. If we go that road (autodiscovery) it would rather be an "mqtt-discovery" adapter instead of a specific one for Tasmota - which wouldn't be a bad thing :-)

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days. Please check if the issue is still relevant in the most current version of the adapter and tell us. Also check that all relevant details, logs and reproduction steps are included and update them if needed. Thank you for your contributions. Dieses Problem wurde automatisch als veraltet markiert, da es in letzter Zeit keine Aktivitäten gab. Es wird geschlossen, wenn nicht innerhalb der nächsten 7 Tage weitere Aktivitäten stattfinden. Bitte überprüft, ob das Problem auch in der aktuellsten Version des Adapters noch relevant ist, und teilt uns dies mit. Überprüft auch, ob alle relevanten Details, Logs und Reproduktionsschritte enthalten sind bzw. aktualisiert diese. Vielen Dank für Eure Unterstützung.

stale[bot] commented 2 years ago

This issue has been automatically closed because of inactivity. Please open a new issue if still relevant and make sure to include all relevant details, logs and reproduction steps. Thank you for your contributions. Dieses Problem wurde aufgrund von Inaktivität automatisch geschlossen. Bitte öffnet ein neues Issue, falls dies noch relevant ist und stellt sicher das alle relevanten Details, Logs und Reproduktionsschritte enthalten sind. Vielen Dank für Eure Unterstützung.