search

ioBroker / ioBroker.sonoff

Control Sonoff-Tasmota devices via ioBroker
MIT License
37 stars 30 forks source link

(GreatSUN) Impl./Fixed potential .STATE.POWER only update synced with… #295

Closed GreatSUN closed 1 year ago

GreatSUN commented 1 year ago

… .POWER switch

I recognized that the switches from NSPanel never get updated on status change, but the .STATUS.POWER changes the other way round (changing the switch in the object it reflects the change on the real switch)

GreatSUN commented 1 year ago

Hi... The changes that have been made are at maximum creating additional entries, so there should not be a null result out of this. @Apollon77 can you have a look and tell me where the issue comes from (as I don't really find it) :-(

Thx, GreatSUN

Apollon77 commented 1 year ago

I would assume an issue in your new code ... see https://github.com/ioBroker/ioBroker.sonoff/actions/runs/3975383836/jobs/6815206975#step:5:270

Cannot parse data "SENSOR": {"Time":"2017-10-05T17:43:19", "DS18x20":{"DS1":{"Type":"DS18B20", "Address":"28FF9A9876815022A", "Temperature":12.2}}, "TempUnit":"C"} - ReferenceError: powerId is not defined

It seems to me that "powerId" is used in https://github.com/ioBroker/ioBroker.sonoff/pull/295/files#diff-1b48bb429de959672dadab9c87c215e19177dd70e3bd932d131ce74294c44cd5R1126 before it is defined

GreatSUN commented 1 year ago

@Apollon77 thx. I have to have a closer look into the manual merging... This was clearly a copy&paste issue.

Apollon77 commented 1 year ago

I have removed the second changelog entry because the isue was never online, so it is still "adding the feature"