ioBroker / ioBroker.sonoff

Control Sonoff-Tasmota devices via ioBroker
MIT License
37 stars 30 forks source link

[security] do not log username and password in clear text (in case of errors) #304

Closed mcm1957 closed 1 year ago

mcm1957 commented 1 year ago

Adapter logs incorret username and password (!) in cleartext.

Client [shellymotion2-nnnnnnnn] has invalid password(-password-) or username(-username-)

Ìn my oppinion security relevant data should NEVER be logged with cleartext. At least passwords should be masked (or omitted in this case). Even in case of incorrect data this information is sensitive as incorrect paswords often are incorrect by simply missing or mixed up characters only.

Adapter Release 2.5.1

mcm1957 commented 1 year ago

see PR https://github.com/ioBroker/ioBroker.sonoff/pull/305