ioBroker / ioBroker.sonoff

Control Sonoff-Tasmota devices via ioBroker
MIT License
37 stars 30 forks source link

Updates and fixes #372

Closed Apollon77 closed 1 month ago

Apollon77 commented 1 month ago
Apollon77 commented 1 month ago

@mcm1957 Please look over it ... thank you

@mattreim also if you like :-)

mcm1957 commented 1 month ago

@Apollon77

.gitignore package-lock.json should not be ignored (would confolict with npm ci as far as I know)

package.json: engines clause should be set to node >= 18 https://github.com/ioBroker/ioBroker.sonoff/blob/61f66081074f0b8ccd363db8d56bb5e5c8dec2a1/package.json#L53

io-package.json: at least js-controller 4.0.28 (?) oder better 5.0.19 should be required at least admin 5, better admin 6.x.x must be required (jsonConfig) https://github.com/ioBroker/ioBroker.sonoff/blob/61f66081074f0b8ccd363db8d56bb5e5c8dec2a1/io-package.json#L153 admin/index.html and admin/index_m.html are obsolete and could be removed as jsonConfig is used

optional: common.license should be replaced by licenseInformation common.title could be removed as far as I know common.materialize is obsolete as adminUi: json is specified - but not 100% sure.

I would suggest to migrate testing to standard @iobroker/testing. But this should ev. be discussed at telegram.

CODE changes: As I do not know the functionality, I cannot ensiure that the changes are ok. I did not see any obvios problems.

Apollon77 commented 1 month ago

materialize would still be used for older admins without jsonconfig. Rest adjusted