search

ioBroker / ioBroker.type-detector

Helper module (not adapter) to detect types of devices
MIT License
8 stars 9 forks source link

bring ct and hue in line with other lights #11

Closed Garfonso closed 4 years ago

Garfonso commented 4 years ago

Those had two "ON" properties (is that meant to work anyway?) -> other light type define ON property for switch role and ON_LIGHT for switch.light role. (The first might target Power on/off and the latter is more specific for light on/off?)

Also the . was not escaped for those two regexp.

blackduck-copilot[bot] commented 4 years ago

Black Duck Security Report

Merging #11 into master will not change security risk.

Added Components

Clean: 5

Removed Components

Clean: 6

Click here to see full report

GermanBluefox commented 4 years ago

Escaping is OK, but double ON is the desired logic. Only the first one will be used.

Garfonso commented 4 years ago

...but double ON is the desired logic. Only the first one will be used.

But why do you have ON and ON_LIGHT in other light devices?

Also I got reports from people where the "wrong" ON is used and there are multiple. This is often the case with lights that have some effects that are switched with a "switch"-role state. Not sure why the wrong ON is used in this cases. I'll check if the right switch was "switch.light" (if I find those reports again ;-) )

Garfonso commented 4 years ago

Ah, I see, you deleted ON_LIGHT everywhere. Ok. 😄