ioBroker / ioBroker.type-detector

Helper module (not adapter) to detect types of devices
MIT License
8 stars 9 forks source link

fix regex with | and clarify name #17

Closed Garfonso closed 3 years ago

Garfonso commented 3 years ago

In a table the | in a regex needs to be escaped, otherwise the part after | is interpreted as new cell (and therefore not displayed at all). Also I added ` to have code tags around the regex which I like a bit more, because regex is kind of code for me (but this is subjective and if you don't want that I can revert it).

Also in telegram the point came up that must not doe mean is not allowed in english and can not be translated word by word. So the old description was wrong there. I changed it quite a bit to also clarify how a user of the results can use the Name part to find states based on function.

lgtm-com[bot] commented 3 years ago

This pull request introduces 1 alert when merging 0733d15797178c8024e56f16e9c5017cddc1b058 into de75826ab25b958fef4984e3a448ca6f95471586 - view on LGTM.com

new alerts:

lgtm-com[bot] commented 3 years ago

This pull request introduces 1 alert when merging 527cafb42b0b3a7cd0da84355c2f00b7365452b4 into de75826ab25b958fef4984e3a448ca6f95471586 - view on LGTM.com

new alerts:

GermanBluefox commented 3 years ago

Thank you