extend channel name recognition schema for flood and fire alarm

ioBroker / ioBroker.type-detector

Helper module (not adapter) to detect types of devices

MIT License

8 stars 9 forks source link

extend channel name recognition schema for flood and fire alarm #38

Closed chris299 closed 11 months ago

chris299 commented 1 year ago

Describe the bug
currently alias "floodalarm" channel type is not recognized being a flood alarm.

Expected behavior
add "floodalarm" to regex in line 572 (also for firealarm similar)

Screenshots & Logfiles
1694715356581-6e5831ca-8a5a-4f64-ae82-15ab68ec0f5d-grafik

1694715423599-521fdd15-4108-49e9-8710-7b1aff923d5e-grafik

Garfonso commented 1 year ago

TBH I'd remove the channelRole requirement for floodAlarm (and also fireAlarm), because the regex is specific enough. Not? It will only accept roles with "flood" (or "fire") at the end.

@GermanBluefox since you introduced the devices originally, what is your opinion? Why did you add the channelRole requirement back then? Some Homematic devices?