ioBroker / ioBroker.type-detector

Helper module (not adapter) to detect types of devices
MIT License
8 stars 9 forks source link

change role of TIME_SUNRISE and TIME_SUNSET #39

Closed Garfonso closed 11 months ago

Garfonso commented 11 months ago

We usually use date in ioBroker context for fixed points in time (which sunrise and sunset are). Also date.sunrise and date.sunset are defined in stateroles.md, time.sunrise and time.sunset are not.

I checked and found only accuweather adapter uses time.sunset and time.sunrise, but it still supplies a complete Date in both states. So the use of time seems to be confusing there, too. So currently adapters reading TIME_SUNRISE should expect a full date in there. The role should reflect that (especially the default role).

Openweathermap adapter already uses the correct role.