search

ioBroker / ioBroker.zwave

Legacy Z-Wave integration using OpenZWave
Other
24 stars 7 forks source link

Simplify js-controller directory resolution #31

Closed AlCalzone closed 6 years ago

AlCalzone commented 6 years ago

Another (JS-only) attempt to solve https://github.com/ioBroker/ioBroker/issues/35

DO NOT MERGE YET, this is currently only a test.

Apollon77 commented 6 years ago

/home/travis/build/ioBroker/ioBroker.zwave/tmp/node_modules/iobroker.zwave/lib/utils.js:33 } catch { / not found / } ^ SyntaxError: Unexpected token { at exports.runInThisContext (vm.js:53:16) at Module._compile (module.js:373:25) at Object.Module._extensions..js (module.js:416:10) at Module.load (module.js:343:32) at Function.Module._load (module.js:300:12) at Module.require (module.js:353:17) at require (internal/module.js:12:17) at Object. (/home/travis/build/ioBroker/ioBroker.zwave/tmp/node_modules/iobroker.zwave/main.js:11:20) at Module._compile (module.js:409:26) at Object.Module._extensions..js (module.js:416:10)

AlCalzone commented 6 years ago

Woops das war ein Überbleibsel aus typescript

AlCalzone commented 6 years ago

The install script hs "npm install --unsafe-perms" somewhere, that should be "npm install --unsafe-perm" without "s"

Apollon77 commented 6 years ago

I will fix that tomorrow. My fault.

AlCalzone commented 6 years ago

I will fix that tomorrow. My fault.

No more need to ;)

Otherwise I think the changes worked. Question is how do we proceed? Just merge or do we need to do some more tests?

Apollon77 commented 6 years ago

Merge and make Forum Thread in testers to get community Test too?!

AlCalzone commented 6 years ago

Sounds good, will do!

Apollon77 commented 6 years ago

Additionally @GermanBluefox should Test locally in his environment too.

If this works too I could push it into all repos and have run all tests and let community test then again with e.g. hm-rpc or an other often used adapter.