search

ioBroker / ioBroker.zwave

Legacy Z-Wave integration using OpenZWave
Other
24 stars 7 forks source link

Cleanup obsolete states #63

Closed cburghardt closed 5 years ago

cburghardt commented 5 years ago

With updates of the underlying ozwave labels of device properties are changing. You can see this massively with the switch from 1.4 to 1.6. As a result you have several states with the same valueId but different labels. This causes issues when you are still working with the old entries, they don't work anymore. The cleanup function causes some additional load during the initial scan but I think it's worth it and better then relying on the user to delete old stuff.

cburghardt commented 5 years ago

@AlCalzone let's give it a shot with the PR ;)

cburghardt commented 5 years ago

@AlCalzone done

AlCalzone commented 5 years ago

@cburghardt LGMT, did you remove the confirmation for hard reset on purpose?

AlCalzone commented 5 years ago

I think I'm going to squash-merge this PR. That means you have to reset your master branch. You can do that locally by doing the following:

git checkout master
git remote add upstream https://github.com/ioBroker/ioBroker.zwave
git fetch upstream
git reset --hard upstream/master
git push --force

In general, I'd recommend creating separate branches for features.

cburghardt commented 5 years ago

@AlCalzone I didn't want to include the hard-reset confirmation in this commit, I wanted to create a separate branch. That's why I reverted.