search

ioBroker / ioBroker.zwave

Legacy Z-Wave integration using OpenZWave
Other
24 stars 7 forks source link

Fix issues 75 and 76 #78

Closed cburghardt closed 4 years ago

cburghardt commented 4 years ago

Disable physics of the map to fix the moving nodes Remove cleanup as there is currently no way to distinguish user renames from library changes Increase version @Apollon77 please review

Apollon77 commented 4 years ago

looks good, we should think about adding an admin-v3 compatible index page too,but this is an other story

Apollon77 commented 4 years ago

could you please also update io-package with version and news? Thank you!

cburghardt commented 4 years ago

io-package included I have also incuded a minor change to the network layout which slightly improves visibility (star shape for controller, boxes for others)

cburghardt commented 4 years ago

Expanded PR to fix #79

cburghardt commented 4 years ago

Ready to be merged from my side. The Travis error is due to the URL of the openzwave repo which can't be resolved.

Apollon77 commented 4 years ago

Hm ... but if travis fails on installing it it will also fail for the users! I would exect that the zip file is called openzwave-1.6.913.zip but the resulting directory is openzwave-1.6.913 and not open-zwave-openzwave-1.6.913 as from the "cd". So we would need to fix the script or?!

Apollon77 commented 4 years ago

looks better :-) I wait for it to finish and merge tomorrow

Apollon77 commented 4 years ago

Thank you very much!

cburghardt commented 4 years ago

Good catch :) I just reinstalled to be sure - looks good Nut sure why the build on Mac fails as I did not modify the general statements so it would have already failed before. Maybe zip -u might fix it.

arteck commented 4 years ago

const version = 'openzwave-1.6.913';

why not master ??

cburghardt commented 4 years ago

@arteck see issue #79