Closed cburghardt closed 4 years ago
This change requires ldconfig
to be allowed in
https://github.com/ioBroker/ioBroker/blob/master/installer.sh and
https://github.com/ioBroker/ioBroker/blob/master/fix_installation.sh
This change requires
ldconfig
to be allowed in https://github.com/ioBroker/ioBroker/blob/master/installer.sh and https://github.com/ioBroker/ioBroker/blob/master/fix_installation.sh
I fear this will create a lot of issues when the people don't know that the fixer is a prerequisite. On the other side this missing ldconfig call is an issue as the installation doesn't work without. Isn't there a chance to prompt for password?
Isn't there a chance to prompt for password?
No. I wouldn't know a foolsafe way to forward such a prompt to the admin UI.
The better approach would be https://github.com/ioBroker/ioBroker.js-controller/issues/348 IMO - which means that each adapter specifies what root commands it needs. The js-controller would have to allow those (manage permissions) and then sudo ldconfig
would be no issue.
Reverted ldconfig change for now
Ready from my side, the travis errors are just the usual strange host not found issues
@AlCalzone or @Apollon77 can you merge if you are fine with that change please?
I squash-merged, so please make sure to use a new branch for your next changes or reset it to the current master