search

ioBroker / ioBroker.zwave

Legacy Z-Wave integration using OpenZWave
Other
24 stars 7 forks source link

Add ldconfig and bump ozw version #93

Closed cburghardt closed 4 years ago

cburghardt commented 4 years ago

Bump ozw version and add ldconfig with a reference to the latest fixer

AlCalzone commented 4 years ago

Also, I squash-merged your last PR (didn't notice it was on the master branch). Please use feature branches in the future. To clean this up:

  1. Reset your master branch to the upstream: 
    git checkout master
git reset --hard upstream/master
  2. Restore the commit: 
    git cherry-pick 638dfd6
cburghardt commented 4 years ago

I agree to the version reasoning but that's probably an overkill for such a small change. Should I revert the version change for now and keep it as master?

AlCalzone commented 4 years ago

The version change is IMO not a breaking change.

Requiring a current fixer version to be able to execute sudo ldconfig is. So we could include the bump in a patch release and do another major release with ldconfig.

cburghardt commented 4 years ago

Reduced the commit to latest openzwave version

AlCalzone commented 4 years ago

LGTM

AlCalzone commented 4 years ago

Squash-merged, please reset your master branch to the upstream (make sure to stash any new changes or put them on a branch):

git fetch upstream
git checkout master
git reset --hard upstream/master
git push -f