search

ioam / topographica

A general-purpose neural simulator focusing on topographic maps.
topographica.org
BSD 3-Clause "New" or "Revised" License
53 stars 32 forks source link

changes to make topographica cloned form github to work outside git directory and some makefile changes (unrelated) #502

Closed mjabri closed 11 years ago

mjabri commented 11 years ago

This pull request is regarding changes to allow the running of topogaphica cloned from github to work outside the topographica directory. The changes are commented with # MAJ changed". Commit file comment in the fork has more description.

jbednar commented 11 years ago

Thanks for submitting this. We've looked over it and are pretty sure that our recent changes to the code take care of these issues in a more general way, but let us know if you are still having problems.

mjabri commented 11 years ago

Yes, looks good. I suggest you add a “stderr=PIPE” to the git describe pipe command in init.py so the user does not get to see a FATAL error message from git on their display when running from outside the git rooted directory, and think something is wrong somewhere.

From: James A. Bednar [mailto:notifications@github.com] Sent: Thursday, March 7, 2013 1:30 PM To: ioam/topographica Cc: M. Jabri Subject: Re: [topographica] changes to make topographica cloned form github to work outside git directory and some makefile changes (unrelated) (#502)

Thanks for submitting this. We've looked over it and are pretty sure that our recent changes to the code take care of these issues in a more general way, but let us know if you are still having problems.

— Reply to this email directly or view it on GitHub https://github.com/ioam/topographica/pull/502#issuecomment-14587363 . https://github.com/notifications/beacon/ZtPUYVGEUarwe5h3C9X6pbPav1hcK0ihhJxQpWntf0JxwL3ARMldZ9SecdlVprSI.gif