search

ioam / topographica

A general-purpose neural simulator focusing on topographic maps.
topographica.org
BSD 3-Clause "New" or "Revised" License
53 stars 32 forks source link

Simplified submodel decorators by using method names #575

Closed jlstevens closed 10 years ago

jlstevens commented 10 years ago

This is my proposed simplification to the new submodel machinery. Now, only the matchconditions decorator requires and argument making the remaining decorators simpler to use.

For now, I have preserved all the original names, partially to help show how things have changes and partially because I do not know what conventions we wish to follow. Suggestions welcome!

EDIT: There are still the annoying param warnings about 'Setting non-Parameter attributes' to fix...

jlstevens commented 10 years ago

My last commit allows matchconditions to be defined across each class instead of requiring them all to be defined at once. I think this change makes use of the matchconditions decorator consistent with the other decorators and allows matchconditions to be declared near where the corresponding parameters are defined.

jlstevens commented 10 years ago

The new changes seem to be working fine so I've gone ahead and merged this PR.