ioam / topographica

A general-purpose neural simulator focusing on topographic maps.
topographica.org
BSD 3-Clause "New" or "Revised" License
53 stars 32 forks source link

Pass src_properties and dest_properties in projection specifiations #577

Closed Tobias-Fischer closed 10 years ago

Tobias-Fischer commented 10 years ago

This little PR changes the projection specification methods to get src_properties and dest_properties passed, rather than the projection itself for which the parameters are set.

jlstevens commented 10 years ago

Doesn't look like this one can be merged in anymore. Please rebase your fork!

Otherwise you suggested changes make sense but I will note that a few things will no longer be accessible when defining projection parameters:

As I don't think either of these things are really necessary, your changes do seem like a nice improvement. Hope resolving the merge conflicts won't be too painful...

Tobias-Fischer commented 10 years ago

Done. Regarding your comments: The projection type is definitely be known. I don't think it's necessary to access this. So far, I have not encountered the necessity to be able to access the sheet types. But as you said, should this in future change, it is an easy fix to add that as a property.