search

ioam / topographica

A general-purpose neural simulator focusing on topographic maps.
topographica.org
BSD 3-Clause "New" or "Revised" License
53 stars 32 forks source link

Cython optimized components don't give a warning or error on failure to compile #603

Open ceball opened 9 years ago

ceball commented 9 years ago

From what I remember, if a weave component fails to compile (but the little weave compilation test passed), you get an error. If a cython component fails to compile, however, you get the unoptimized fallback with only printed messages.

Assuming I got that right, should I make the cython behavior be like the current weave behavior (i.e. at least a warning if a component fails to compile)? Or was it a deliberate decision to have no warning/error?

philippjfr commented 9 years ago

No this wasn't deliberate. I put together the Cython components on a trip over a few days and never really polished it since DICE didn't have Cython available. Now that's the case, we should definitely fix everything and switch over. Would be great if you had the time to do this. I've already looked into building the extension correctly and we've been discussing the best way to go about it here, however I can't find a solution that doesn't require including and building it in a setup script at the root level.