ioam / topographica

A general-purpose neural simulator focusing on topographic maps.
topographica.org
BSD 3-Clause "New" or "Revised" License
53 stars 32 forks source link

Projection input/output function refactor #608

Closed jlstevens closed 9 years ago

jlstevens commented 9 years ago

Projection input and output functions were not being handled properly; state_push and state_pop was not being called for any of these transfer functions. This PR implements two changes:

All the training tests pass after making these modification and I don't foresee any other issues e.g snapshots should work fine after this change. I've submitted this as a PR to make sure everyone is happy with these commits before touching components in topo.base.

EDIT: As only a few lines have changed, I am happy to make these commits directly to master instead to avoid creating an additional PR commit.

philippjfr commented 9 years ago

Looks good to me. Shouldn't affect anything since no model that I'm aware of is actually using projection input/output functions.

jbednar commented 9 years ago

Looks good; merge it!