search

ioan-chera / eureka-editor

Eureka is a cross-platform map editor for the DOOM engine games.
http://eureka-editor.sourceforge.net/
66 stars 12 forks source link

Sourceforge Ticket 45: Eureka shouldn't store user specific data in the map WAD #124

Closed sink666 closed 2 years ago

sink666 commented 2 years ago

Solved this ticket. The Eureka lump shouldn't store user data in the form of absolute paths in the map WAD. The changes made affect only the Eureka lump writer and parser.

sink666 commented 2 years ago

did you intentionally add the rule that entire paths can be attempted after the PWAD directory if not found? What if they start with D:\, based on pwadPath += resBackup, is it going to happen that D:\Wads\C:\Games\Doom\res.wad? Haven't tested that though…

No, it was a naive assumption. Since the path returned by GetRelativePath is relative to the current working directory, I assumed that if the resource or resource folder is in the same folder as the pwad I could append it to the pwad path minus basename. I hadn't fully considered or tested what using a resource from another disk might do with this method.

ioan-chera commented 2 years ago

I've cloned your changes into a branch here called pr124-relpath. Thanks! I'll work on top of it and see to make it fit.