search

ioan-chera / eureka-editor

Eureka is a cross-platform map editor for the DOOM engine games.
http://eureka-editor.sourceforge.net/
64 stars 12 forks source link

Fix a couple bugs flagged by gcc 13.3 #164

Closed epg closed 2 months ago

epg commented 2 months ago

Merges clean with commit c3cebe553a5fcdfd5b416478b452dfdf9ac68d44 where both bugs are still present.

Thanks for taking over and putting out 2.0!

ioan-chera commented 2 months ago

Oh man, this was a use of strncpy where I knew precisely what I was doing, applying its algorithm as intended on a fixed size char array (not string). Guess that historically awful use ruined it and we can't use it legit-like. I will approve your PR, thank you, if it solves GCC warnings as errors (for now I have no plans to retrace from this decision).

ioan-chera commented 2 months ago

Applied the changes with the given corrections. Thank you!