search

ioannnikulin / minishell

2 stars 0 forks source link

protecting master #59

Closed ioannnikulin closed 1 month ago

cr3mebrulee commented 1 month ago

@ioannnikulin so, i got ci.yml is a configuration file for GitHub Actions, which is a CI/CD service. This file defines automated workflows that run on specific events, like when a pull request is made to a branch.

Your #59 PR makes PR to dev and master triggering the workflow. Is here something more what i should to know about? What does this file do?

ioannnikulin commented 1 month ago

@cr3mebrulee a job called CI is run everytime a PR into dev/master is created. This job includes downloading all necesary stuff for the build, build, and internal tests. The result (success, I.e. no errors; or failure) is shown in the respective PR. Previously it was only shown, and only for dev. Current setup turns it on also for master, and makes a successful check mandatory to allow a merge. The mandatory setup is not here, it's in the repository settings in GitHub. This PR only enables checks for master - on the dame condition as dev.

ioannnikulin commented 1 month ago

@cr3mebrulee if you\re fine with the changes, please approve here image otherwise I don't have the merge button :) if you have any other questions though, feel free to ask