search

iobio / clin.iobio

Clin.iobio - Workflow and reporting for iobio variant analysis pipeline
10 stars 5 forks source link

Selecting variants that aren't in the left menu doesn't work #145

Open AlistairNWard opened 4 years ago

AlistairNWard commented 4 years ago

If I'm in a gene and select a variant that is not in the list of prioritized variants at the left, I can still mark this as Significant, but:

  1. The badge under findings only counts the variants in the left bar,
  2. The variant I just added cannot be easily discovered again as it isn't in the left menu

As a result, if I mark up any variants that were not originally found, they will be immediately lost. We might want to discuss how we want to fix this, but we could:

  1. Put the annotated variant in the reviewed category
  2. Update the badge to reflect the number of observed pathogenic variants
  3. Update the number of Variants under Review Variants to include this variant

If the significance is set to Not significant, it would be removed from the Reviewed category, and will not be put into any other category. That is probably fine, but we could consider creating a new category to house reviewed variants that aren't important.

WilliamRichards2017 commented 4 years ago

A pull request to fix this issue has been opened in gene

https://github.com/iobio/gene.iobio.vue/pull/483

AlistairNWard commented 4 years ago

This seems to be working