Added selectVariantAnnotationDialog #846

[YangQi007]

Added selectVariantAnnotationDialog, the mosaic option is not completed yet.

[tonydisera]

Hi @YangQi007. I've left comments on issue #846.

[tonydisera]

Hi @YangQi007. I pulled down your branch and tested this morning. There are some fixes I requested in the last pull request that are not yet fixed. Here are screen prints with comments.

[tonydisera]

See comments above ^

[YangQi007]

Hi, @tonydisera I fixed the user interface based on your comments. Here, there is a thing I would like to bring up to your attention. When parsing the vcf file, there are abbreviations for annotations, but not for calling the mosaic API. So on the user interface, the UI is not consistent.

[tonydisera]

@YangQi007, I like the way the interface looks with the fixed-width columns. It is okay that the Mosaic variant annotations look a bit different.

[tonydisera]

@YangQi007, there is a problem with the tooltip on the annotations in VariantInspectCard. When I hover over the annotation abbreviation, the screen flickers and the tooltip shows at the bottom of the panel rather than by the label I am hovering over.

[tonydisera]

@YangQi007 , please change the "select" button to have the following styling. This will align with the header.

And the icon within the button should have font-size: 22px

[tonydisera]

@YangQi007, we can probably have a narrower fixed width so that the values are closer to the labels.

[tonydisera]

On the "select annotations" dialog, there are still a few format issues to address. Also, it would be nice to have a "select all" checkbox so that the user doesn't have to click on every annotation.

[tonydisera]

Also, let's remove 'custom' from 'Custom annotations'. I think this will look better.

[YangQi007]

@YangQi007, we can probably have a narrower fixed width so that the values are closer to the labels.

As to your comment about narrowing down the fixed width. I did that because in mosaic the name of annotations are longer. So if make the width smaller, the format of name of annotations will be not consistent.

[tonydisera]

@YangQi007, we can probably have a narrower fixed width so that the values are closer to the labels.

As to your comment about narrowing down the fixed width. I did that because in mosaic the name of annotations are longer. So if make the width smaller, the format of name of annotations will be not consistent.

Good point, @YangQi007. Let's leave the fixed width to your proposed width.

[tonydisera]

Hi @YangQi007 - I just pulled down your branch and tested. Some of the items haven't been fixed yet. Have you pushed all of your changes? I don't see the "Select all" checkbox on the 'Select annotations' dialog and the number of annotations next to the header. The tooltip still flickers on the VariantInspectCard when I hover over the icon. Also the tooltip isn't placed correctly.

[YangQi007]

Hi @YangQi007 - I just pulled down your branch and tested. Some of the items haven't been fixed yet. Have you pushed all of your changes? I don't see the "Select all" checkbox on the 'Select annotations' dialog and the number of annotations next to the header. The tooltip still flickers on the VariantInspectCard when I hover over the icon. Also the tooltip isn't placed correctly.

You got email for PR? I didn't commit them yet. I just fixed the tooltip flicking and changed their position. I am still working on selectAll feature.

[tonydisera]

I see. The 'review requested' (above) must happen when a push to your branch is made.

[YangQi007]

I see. The 'review requested' (above) must happen when a push to your branch is made.

Hi, @tonydisera just pushed the changes, now it should be all there. Please check it out.

[YangQi007]

@tonydisera I didn't add a new checkbox for the deselect option because the 'Cancel' button has the same functionality.

[tonydisera]

@YangQi007 This looks great. These last changes make the UI look really polished. I am merging this pull request.