iobio / gene.iobio

Gene.iobio vue
MIT License
55 stars 11 forks source link

Hitting the 'cancel' button in SelectVariantAnnotationsDialog should not clear out all of the checked annotations #1027

Closed tonydisera closed 11 months ago

tonydisera commented 11 months ago

When the user hits the 'Cancel' button, the current behavior results in all previously checked annotations being unchecked. This is not the expected behavior. When the user cancels out of a dialog, it should clear out any state changes made since the time the dialog was opened.

Let's say the user first pulled up the dialog and selected 5 annotations from the 'Annotations' list. They spent a certain amount of time and energy finding the fields they wanted to display. Now they click through different variants and realize that they want to display another annotation. So they open the dialog and try to find the annotation. They click an annotation then then realize this probably is the one they are interested in. So they cancel out of the dialog. Now the 5 previously selected annotations have disappeared and they have to re-check them.

So when the cancel button is pressed, the SelectVariantAnnotationsDialog should reset to the previous state. You have this state in the property field.