iobio / gene.iobio

Gene.iobio vue
MIT License
55 stars 11 forks source link

Add ability for user to interpret variant significance #169

Closed tonydisera closed 3 years ago

tonydisera commented 6 years ago

@AlistairNWard @mvelinder Here is the preliminary feature for classifying variants. This feature still needs refinement, but I wanted to get something out there for you guys to play with.

You can try by launching: http://clin.iobio.io or http://dev.gene.iobio Screen Shot 2018-08-07 at 5.27.31 PM.png

When you click on the badge, the popup will appear, allowing you to select a different 'Interpretation' and edit the notes. I haven't implemented multiple notes yet. Could this wait for another version release?

Screen Shot 2018-08-07 at 5.27.40 PM.png

AlistairNWard commented 6 years ago

I like this. I definitely think this is as much as we need before putting in front of the clinicians.

My only comment is whether there is just too much information on screen now, and whether it might be worth simplifying. So for example, in the left list, do we really need to know the coordinates, alleles, rsid etc? I wonder if at this level, all we really need to know is that variant #1 falls under the Pathogenic/Likely pathogenic category and then have the symbols that highlight major attributes of the variant? A possible thought would then be that the list is super simple, with the gene and a few symbols and a clear button for reviewing. Then we could make the modal a bit more comprehensive, with details of the variant appearing at the top of the modal, and then the notes and interpretation available. Thoughts?

tonydisera commented 6 years ago

Funny. I was concerned with the same design issue last night as well! It is just to fucking much. I like your idea of scaling back on the entries for flagged variants. I've also been playing around with some other design ideas to make the UI less "heavy" and bring more attention to the important elements.

Here is something I was playing around with last night. I pulled the cool font that @mvelinder is using in his new iobio website, removed header icons from the flagged variants, and made the nav bar white.

screen shot 2018-08-08 at 9 47 45 am
AlistairNWard commented 6 years ago

I like it. Going a little further...

Asset 1.png

tonydisera commented 6 years ago

Yep, I think we might be converging on a better design! I'm pretty stoked.

tonydisera commented 6 years ago

@mvelinder Your thoughts?

tonydisera commented 6 years ago

@AlistairNWard Better? I kept AF and consequence, especially since we tend to set the AF filter pretty loosely.

Screen Shot 2018-08-08 at 1.53.19 PM.png

AlistairNWard commented 6 years ago

Yeah, those are probably worth keeping available at a glance. Definitely looks better IMO.