iobio / gene.iobio

Gene.iobio vue
MIT License
58 stars 11 forks source link

Need to remove old unused code #496

Open anderspitman opened 4 years ago

anderspitman commented 4 years ago

I noticed that gene is still making requests to ws://null/. This is an artifact of the old backend API which used websockets. We need to remove that code, as well as a bunch of other things involved in the old local file support (bgzf, compression, etc).

mvelinder commented 4 years ago

Thank you @anderspitman related to the old backend expiration issues @yiq mentioned at lab meeting, correct?

adityaekawade commented 4 years ago

This particular request ws://null/ can be another reason why gene.iobio is shown as not secure?? Console message:

Screen Shot 2020-04-29 at 3 38 50 PM

The other reason that you have mentioned is http://iobio for image source. Related to issue: #471

anderspitman commented 4 years ago

@mvelinder it's not completely related. I would say that is a higher priority so we can turn off the old backend. This is essentially cleanup.

AlistairNWard commented 3 years ago

Is this pressing?

anderspitman commented 3 years ago

I would say no (but it needs to be kept open), unless it's causing https://github.com/iobio/gene.iobio.vue/issues/755, then yes.

anderspitman commented 3 years ago

The amount of code that needs to be removed to fix the particular error @adityaekawade mentions should be quite easy to take care of.

anderspitman commented 3 years ago

Removing iobio.js, iobio.min.js, and binary.js from here:

https://github.com/iobio/gene.iobio.vue/tree/master/client/app/third-party

and here:

https://github.com/iobio/gene.iobio.vue/blob/master/server/views/index.html

may be it.

But there are a bunch of other unused files in there that we need to clean up at some point.

AlistairNWard commented 2 years ago

@anderspitman @tonydisera Do we still need to address this?

anderspitman commented 2 years ago

Yep

tonydisera commented 2 years ago

Yep.