search

iobio / gene.iobio

Gene.iobio vue
MIT License
55 stars 11 forks source link

Added inform user text#943 #961

Closed YangQi007 closed 10 months ago

YangQi007 commented 11 months ago

Added an inform user text to ask the user to select a sample before loading

tonydisera commented 10 months ago

Hi @YangQi007 - I tested this branch and ran into a few issues.

  1. In the case where there is only one sample and it is default selected for a vcf, the message is still showing. Since the sample is selected (and the load button is enabled), this message shouldn't show.
Screenshot 2023-08-09 at 2 32 37 PM

  1. In the case where there are multiple samples, and the user selects a sample, the warning message still appears. It should not be shown once the sample is selected.

    Screenshot 2023-08-09 at 2 33 20 PM

  2. The wording of the message is a little confusing ('...before loading'). Let's just have the message be 'Select a sample from the dropdown'

YangQi007 commented 10 months ago

@tonydisera the message showing is updated. Thanks for explaining to me about the v-if and v-model!