iobio / genepanel.iobio

Genepanel.iobio: generate list of genes based on suspected conditions and phenotypes.
https://genepanel.iobio.io/
11 stars 3 forks source link

Auto-save causing problems in gene.iobio! #289

Open tonydisera opened 6 years ago

tonydisera commented 6 years ago

Adit, please make sure all new features in genepanel.iobio are testing inside clin.iobio. Right now, the auto-save in genepanel.iobio is sending messages numerous messages to clin, which is causing gene.iobio to get new 'apply-genes' messages over and over. Right now, I would advice removing this code since stability will be the most important goal this next week in preparation for the demo on Oct 15th.

tonydisera commented 6 years ago

Screen Shot 2018-10-07 at 4.32.37 PM.png

adityaekawade commented 6 years ago

Hi Tony, Sorry, I am out at the moment. You can disable it right now and I will look for a better solution. I think I am calling autoSaveGenes() with a setInterval inside the receive clin function. Instead, call the copyAll().

On Sun, 7 Oct 2018 at 16:42, Tony Di Sera notifications@github.com wrote:

[image: Screen Shot 2018-10-07 at 4.32.37 PM.png] https://camo.githubusercontent.com/2c8cadcd34b615a5d82edf311b3900d0c30a0f97/68747470733a2f2f776166666c65696f2d6469726563742d75706c6f6164732d70726f64756374696f6e2e73332e616d617a6f6e6177732e636f6d2f75706c6f6164732f3537353966306234306233376230306530306537643364342f3132353531366336366538326337323861636532316530643436646239373838323638373864653962636531623035376534306661306335373130623736323336343534663436623731393161333763663131313239346635633538356563633363346134333536626362626436373166336535373836323830346530656263643833383062376463663666313466616565383234646261303162613231643934643836653762343838313864326634326636376236643564623130363334373466346463626564353732376132393834316339356466353433653834383537613531303366363265333766323433312e706e67

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/iobio/genepanel.iobio/issues/289#issuecomment-427693480, or mute the thread https://github.com/notifications/unsubscribe-auth/APh8Kfva35fk7cyGApyDLhH7YulEbxY4ks5uioNbgaJpZM4XMEkn .

tonydisera commented 6 years ago

Okay. I can comment out the auto-save code. But now, it looks like the 'apply-genes' message is not getting sent to clin.iobio so after searching in GTR, Phenolyzer tabs, nothing is showing up in gene.

adityaekawade commented 6 years ago

I have disabled the auto-save currently and 'apply-genes' message is sent to clin.