iobio / vcf.iobio.io

MIT License
27 stars 11 forks source link

Flagging variants for NOT PASSING FILTER CRITERIA is inconsistent. #42

Closed tonydisera closed 7 years ago

tonydisera commented 7 years ago

The VCF Filter values (e.g., PASS, ., etc) are populated based on the variants that have been analyzed across all loaded genes. This isn't a complete solution, because variants with '.' filters won't be considered as 'FLAGGED FOR NOT MEETING FILTER CRITERIA' until a variant with a 'PASS' filter is encountered. Take, for example the demo data. When first loaded, variants for RAI1, which all have a filter of '.', are not flagged.

screen shot 2017-04-27 at 9 56 02 pm

After gene PDGFB is selected, a variant with a 'PASS' filter is encountered.

screen shot 2017-04-27 at 9 56 26 pm

Select RAI1 again. Now its variants are flagged for not meeting filter criteria.

screen shot 2017-04-27 at 9 56 37 pm

I think that the solution is to have a priori knowledge of all possible filter values used in the loaded VCF.